diff --git a/CHANGELOG.txt b/CHANGELOG.txt index 411ed546..937702b5 100644 --- a/CHANGELOG.txt +++ b/CHANGELOG.txt @@ -32,7 +32,7 @@ bugfix: - fix service-edit actions=move - problem with API mode for TMP objects - fix class AddressRuleContainer - fix is related address-merger for snathost replacement - fix memory calculation for specific situations -- fix memory issue if own addressgroup/servicegroup is added as a subgroup in an offline configuration file +- fix memory issue if own addressgroup/servicegroup is added as a subgroup in an offline configuration file (move from error to warning) diff --git a/lib/object-classes/class-AddressGroup.php b/lib/object-classes/class-AddressGroup.php index 58e6cac9..9f038ea5 100644 --- a/lib/object-classes/class-AddressGroup.php +++ b/lib/object-classes/class-AddressGroup.php @@ -664,7 +664,10 @@ public function & expand($keepGroupsInList=false) if( $object->isGroup() ) { if( $this->name() == $object->name() ) - derr( "please cleanup your configuration file, addressgroup with name: ".$this->name()." is added as subgroup!!!" ); + { + mwarning( "addressgroup with name: ".$this->name()." is added as subgroup to itself, you should review your XML config file" ); + continue; + } /** @var AddressGroup $object */ $tmpList = $object->expand(); diff --git a/lib/object-classes/class-ServiceGroup.php b/lib/object-classes/class-ServiceGroup.php index 9600abcd..b0d686dd 100644 --- a/lib/object-classes/class-ServiceGroup.php +++ b/lib/object-classes/class-ServiceGroup.php @@ -572,7 +572,11 @@ public function &expand($keepGroupsInList=false) if( $object->isGroup() ) { if( $this->name() == $object->name() ) - derr( "please cleanup your configuration file, servicegroup with name: ".$this->name()." is added as subgroup!!!" ); + { + mwarning( "servicegroup with name: ".$this->name()." is added as subgroup to itself, you should review your XML config file" ); + continue; + } + $ret = array_merge( $ret, $object->expand() ); if( $keepGroupsInList ) diff --git a/utils/common/actions-address.php b/utils/common/actions-address.php index fefca733..354a4d8f 100644 --- a/utils/common/actions-address.php +++ b/utils/common/actions-address.php @@ -710,7 +710,7 @@ ); -//TODO: does not use the filtered objects 20180202 + AddressCallContext::$supportedActions[] = Array( 'name' => 'replaceByMembersAndDelete', 'MainFunction' => function ( AddressCallContext $context )