[Java] [Feign] Add support for Feign 13 #1335
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasls
commented
Feb 24, 2025
| @@ -12,7 +12,7 @@ | |||
|
|
|||
| <groupId>io.swagger.codegen.v3</groupId> | |||
| <artifactId>swagger-codegen-generators</artifactId> | |||
| <version>1.0.56</version> | |||
| <version>1.0.57-SNAPSHOT</version> | |||
There was a problem hiding this comment.
Not sure if I should have bumped it here, let me know if I should revert
4 tasks
|
Hey @frantuma, this part of the fix to support Feign 13, fixing the 3.0 generator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As pointed out in the issue swagger-api/swagger-codegen#12524, compilation fails for generated classes when Feign 13 and above are used.
The reason is version 13 adds an overload to the RetryableException constructor with the type Long instead of Date, and the value is passed as null causing the compiler to fail to resolve the constructor.
This PR applies swagger-api/swagger-codegen#12525 for version 3.0