server: Extract Retry state machine out of run_with_retries #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now the state machine is only used for the implementation of run_with_retries, but it will be used directly in the future, to get around control flow analysis issues with run_with_retries.
svix-james
approved these changes
Feb 8, 2024
|
Failures in #1188 figured out. It's probably best to merge the commit from the PR as part of that one, not on its own. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now the state machine is only used for the implementation of run_with_retries, but it will be used directly in the future, to get around control flow analysis issues with run_with_retries.
Extracted out of #1188 because CI is consistently failing there and I'm wondering whether I botched the retry state machine.