Upgrade redis-rs/bb8 again #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the reconfigured clustered redis healthcheck, I believe we're safe to upgrade redis again. Note: This version of redis-rs imposes a default 1-second timeout on establishing connections to cluster nodes. I don't see any reason at the moment to change this, but we may need to consider exposing this as a configurable parameter in the future.
jaymell
force-pushed
the
upgrade-redis-again
branch
from
489f50b to
bd6f4b5
Compare
|
An alternative approach could be to explicitly disable the redis connection timeouts. |
svix-jplatte
approved these changes
Apr 25, 2024
|
@svix-jplatte Do you have any concerns about the default 1-second connection timeout? |
|
Hm, were the errors we saw with the upgrade last time timeout-related? If not, seems fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the reconfigured clustered redis healthcheck,
I believe we're safe to upgrade redis again.
Note: This version of redis-rs imposes a default 1-second
timeout on establishing connections to cluster nodes. I don't
see any reason at the moment to change this, but we may need
to consider exposing this as a configurable parameter in the future.