Skip to content

Commit

Permalink
Merge pull request #35 from svix/jplatte/up-sqs
Browse files Browse the repository at this point in the history
Upgrade SQS dependencies
  • Loading branch information
svix-jplatte authored Feb 19, 2024
2 parents 7b49932 + 2bf7125 commit cd40d1a
Show file tree
Hide file tree
Showing 9 changed files with 13 additions and 15 deletions.
4 changes: 2 additions & 2 deletions omniqueue/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ edition = "2021"

[dependencies]
async-trait = "0.1"
aws-config = { version = "0.55", optional = true }
aws-sdk-sqs = { version = "0.25", optional = true }
aws-config = { version = "1.1.5", features = ["behavior-version-latest"], optional = true }
aws-sdk-sqs = { version = "1.13.0", optional = true }
bb8 = { version = "0.8", optional = true }
bb8-redis = { version = "0.14.0", optional = true }
futures-util = { version = "0.3.28", default-features = false, features = ["async-await", "std"], optional = true }
Expand Down
2 changes: 0 additions & 2 deletions omniqueue/src/backends/sqs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,6 @@ impl QueueConsumer for SqsQueueConsumer {
.map_err(QueueError::generic)?;

out.messages()
.unwrap_or_default()
.iter()
.map(|message| -> Result<Delivery, QueueError> { Ok(self.wrap_message(message)) })
.next()
Expand All @@ -293,7 +292,6 @@ impl QueueConsumer for SqsQueueConsumer {
.map_err(QueueError::generic)?;

out.messages()
.unwrap_or_default()
.iter()
.map(|message| -> Result<Delivery, QueueError> { Ok(self.wrap_message(message)) })
.collect::<Result<Vec<_>, _>>()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#![cfg(feature = "gcp_pubsub")]

//! Support for Google Cloud Pub/Sub.
//!
//! In this system subscriptions are like queue bindings to topics.
Expand Down
10 changes: 10 additions & 0 deletions omniqueue/tests/it/main.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
#[cfg(feature = "gcp_pubsub")]
mod gcp_pubsub;
#[cfg(feature = "rabbitmq")]
mod rabbitmq;
#[cfg(feature = "redis")]
mod redis;
#[cfg(feature = "redis_cluster")]
mod redis_cluster;
#[cfg(feature = "sqs")]
mod sqs;
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#![cfg(feature = "rabbitmq")]

use lapin::options::ExchangeDeclareOptions;
use lapin::types::AMQPValue;
use lapin::{
Expand Down
2 changes: 0 additions & 2 deletions omniqueue/tests/redis.rs → omniqueue/tests/it/redis.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#![cfg(feature = "redis")]

use omniqueue::{
backends::redis::{RedisConfig, RedisQueueBackend},
queue::{consumer::QueueConsumer, producer::QueueProducer, QueueBackend, QueueBuilder, Static},
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#![cfg(feature = "redis_cluster")]

use omniqueue::{
backends::redis::{RedisClusterQueueBackend, RedisConfig},
queue::{consumer::QueueConsumer, producer::QueueProducer, QueueBackend, QueueBuilder, Static},
Expand Down
2 changes: 0 additions & 2 deletions omniqueue/tests/sqs.rs → omniqueue/tests/it/sqs.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
#![cfg(feature = "sqs")]

use aws_sdk_sqs::Client;
use omniqueue::{
backends::sqs::{SqsConfig, SqsQueueBackend},
Expand Down
2 changes: 1 addition & 1 deletion testing-docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ services:
- ./_rabbit/plugins:/usr/lib/rabbitmq/plugins

elasticmq: # Drop-in SQS replacement
image: docker.io/softwaremill/elasticmq:1.3.14
image: docker.io/softwaremill/elasticmq-native:1.5.7
ports:
- "9324:9324"
- "9325:9325"
Expand Down

0 comments on commit cd40d1a

Please sign in to comment.