Skip to content

Commit

Permalink
ci: Remove unnecessary extra cargo command args
Browse files Browse the repository at this point in the history
For clippy and test, --all is deprecated in favor of --workspace, but is
also a no-op for workspaces unless some workspace members are not
default members.

For fmt, it already operates on the whole workspace by default; --all
just additionally includes non-workspace path dependencies (super rare
and should likely never be committed anyways).
  • Loading branch information
svix-jplatte committed Feb 6, 2024
1 parent 1b1d25a commit 09f2eed
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ jobs:
- uses: Swatinem/rust-cache@v1

- name: Clippy
run: cargo clippy --all --all-targets --all-features -- -D warnings
run: cargo clippy --all-targets --all-features -- -D warnings

- name: rustfmt
run: cargo fmt --all -- --check
run: cargo fmt -- --check

- name: Start test dependencies
run: docker-compose -f "./testing-docker-compose.yml" up -d
Expand All @@ -37,7 +37,7 @@ jobs:
AWS_DEFAULT_REGION: localhost
AWS_ACCESS_KEY_ID: x
AWS_SECRET_ACCESS_KEY: x
run: cargo test --all --all-features
run: cargo test --all-features

- name: Stop test dependencies
run: docker-compose -f "./testing-docker-compose.yml" down

0 comments on commit 09f2eed

Please sign in to comment.