Skip to content

Commit

Permalink
realtek: Switch ApresiaLightGS120GT-SS RTL8231 driver
Browse files Browse the repository at this point in the history
Switch the implementation for the RTL8231 GPIO expander to the new
driver.

This allows specifying the GPIO driving the RTL8231's reset as a proper
MDIO reset line, so the gpio-hog can be dropped. Since it was pinned at
a high level, the reset line is actually active-low (i.e. high when not
in reset).

Since the GPIO used for the reset key is capable of hardware debouncing,
also add the (only supported) debounce interval of 100ms.

Signed-off-by: Sander Vanheule <sander@svanheule.net>
  • Loading branch information
svanheule committed Jan 18, 2025
1 parent a2c49a5 commit 3afd053
Showing 1 changed file with 27 additions and 13 deletions.
40 changes: 27 additions & 13 deletions target/linux/realtek/dts/rtl8382_apresia_aplgs120gtss.dts
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@
compatible = "gpio-keys-polled";
poll-interval = <20>;

pinctrl-names = "default";
pinctrl-0 = <&reset_key_debounce>;

reset {
label = "reset";
gpios = <&gpio1 33 GPIO_ACTIVE_LOW>;
Expand All @@ -61,13 +64,6 @@
open-source;
};

gpio1: rtl8231-gpio {
compatible = "realtek,rtl8231-gpio";
#gpio-cells = <2>;
gpio-controller;
indirect-access-bus-id = <0>;
};

i2c0: i2c-gpio-0 {
compatible = "i2c-gpio";
sda-gpios = <&gpio1 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
Expand Down Expand Up @@ -134,12 +130,30 @@
};
};

&gpio0 {
rtl8231_reset {
gpio-hog;
gpios = <1 GPIO_ACTIVE_HIGH>;
output-high;
line-name = "rtl8231-reset";
&mdio_aux {
status = "okay";

reset-gpios = <&gpio0 1 GPIO_ACTIVE_LOW>;
reset-delay-us = <1000>;
reset-post-delay-us = <10000>;

gpio1: expander@0 {
compatible = "realtek,rtl8231";
reg = <0>;

gpio-controller;
#gpio-cells = <2>;
gpio-ranges = <&gpio1 0 0 37>;

reset_key_debounce: reset-key-pins {
pins = "gpio33";
input-debounce = <100000>;
};

led-controller {
compatible = "realtek,rtl8231-leds";
status = "disabled";
};
};
};

Expand Down

0 comments on commit 3afd053

Please sign in to comment.