Fixed dead links #604
Open
Fixed dead links #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardys
reviewed
Feb 28, 2025
| @@ -984,7 +984,7 @@ The following is an example of the `mgmt-cluster.yaml` file with the `embeddedAr | |||
| Make sure to the listed images contain the component versions you need. | |||
| ==== | |||
|
|
|||
| The `rancher-turtles-airgap-resources` helm chart must also be added, this creates resources as described in the https://turtles.docs.rancher.com/getting-started/air-gapped-environment[Rancher Turtles Airgap Documentation]. This also requires a turtles.yaml values file for the rancher-turtles chart to specify the necessary configuration. | |||
| The `rancher-turtles-airgap-resources` helm chart must also be added, this creates resources as described in the https://documentation.suse.com/cloudnative/cluster-api/v0.16/en/getting-started/air-gapped-environment.html[Rancher Turtles Airgap Documentation]. This also requires a turtles.yaml values file for the rancher-turtles chart to specify the necessary configuration. | |||
There was a problem hiding this comment.
The version used in Edge 3.2 is 0.14.1 so we should probably use https://documentation.suse.com/cloudnative/cluster-api/v0.14/en/index.html.
To ensure this isn't perpetually outdated we should probably also add a version e.g here and use an attribute?
There was a problem hiding this comment.
Actually looks like we already have one but in links.adoc
./asciidoc/edge-book/links.adoc::rancher-turtles-docs-version: v0.14
./asciidoc/components/turtles.adoc:See Rancher Turtles documentation at https://turtles.docs.rancher.com/turtles/{rancher-turtles-docs-version}
|
Thanks, overall lgtm but one question about the hard-coded turtles version. Also I'm wondering does it make sense to move all the links into links.adoc for consistency? (not necessarily in this PR, but in future) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #145