Removed some awkward wording (issue #299) #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardys
reviewed
Feb 27, 2025
asciidoc/guides/metallb-k3s.adoc
Outdated
|
|
||
| In this example, our DHCP pool is `192.168.122.100-192.168.122.200` (yes, three IPs, see <<traefik-and-metallb,Traefik and MetalLB>> for the reason of the extra IP) for a `192.168.122.0/24` network, so anything outside this range is OK (besides the gateway and other hosts that can be already running!) | ||
| In this quick start, L2 mode will be used. | ||
| This means we do not need any special network gear but three free IPs within |
There was a problem hiding this comment.
I would replace "gear" with "equipment" here?
There was a problem hiding this comment.
Sounds good, made the respective change
|
Looks good, thanks @fsundermeyer! One small suggestion added. For future PRs note that if you add a line like: Fixes: #299 to the PR description, the relevant issue gets auto-closed when the PR merges (this doesn't work if you only mention the issue in the PR title) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #299