Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing extra quotes in sed command #515

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agracey
Copy link
Contributor

@agracey agracey commented Jan 6, 2025

The command as written is broken. I believe this is what's intended?

@hardys
Copy link
Contributor

hardys commented Jan 6, 2025

The fix seems fine, but I'm wondering if we should still document this, as I don't think it's currently fully tested/supported? @rdoxenham what are your thoughts?

@rdoxenham
Copy link
Contributor

Good point @hardys. Let me bring in @bruth - do we want to look at refactoring these docs so they align well with what you are the team are working on? We want to make sure that we're accurately capturing the installation steps but also ensuring that we have good test and support coverage. Thanks!

Copy link
Contributor

@atanasdinov atanasdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This guide assumes OSX where sed requires the ' ' part.

P.S. I'm fine with updating this but we also have to go back and update the host references and someone would have to retest it.

@rdoxenham
Copy link
Contributor

This guide assumes OSX where sed requires the ' ' part.

P.S. I'm fine with updating this but we also have to go back and update the host references and someone would have to retest it.

Or alternatively, we add a note to say to the user to use gsed on a Mac?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants