Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django serialization support #41

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

amyasnikov
Copy link
Contributor

Django has built-in serializers. To support serializing Django models which contain PydanticSchemaField it is necessary to re-implement value_from_object(). Without this fix Django serialization encounters errors if a model contains PydanticSchemaField fields.

amyasnikov and others added 2 commits January 9, 2024 17:51
@surenkov surenkov added this to the 0.3 milestone Jan 9, 2024
@surenkov surenkov added the django label Jan 9, 2024
@surenkov
Copy link
Owner

surenkov commented Jan 9, 2024

Hi @amyasnikov, thank you for pointing on this issue!
Looks like the primary issue is in value_to_string method -- I pushed an update to your PR here. Also added some tests for it.

I think these changes will be released the next week -- master branch is already frozen for 0.3.0 release. In meantime I can backport it for 0.2.* branch.

@surenkov surenkov merged commit f0801e5 into surenkov:master Jan 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants