Skip to content

Commit

Permalink
image search response restructured
Browse files Browse the repository at this point in the history
  • Loading branch information
suprjinx committed Jul 17, 2024
1 parent df67314 commit 7ff1133
Showing 1 changed file with 27 additions and 16 deletions.
43 changes: 27 additions & 16 deletions pkg/api/aim/api/response/run.go
Original file line number Diff line number Diff line change
Expand Up @@ -487,10 +487,10 @@ func NewStreamArtifactsResponse(ctx *fiber.Ctx, rows *sql.Rows, runs map[string]

if err := func() error {
var (
runID string
runData fiber.Map
traces map[string]fiber.Map
cur int64
runID string
runData fiber.Map
tracesMap map[string]fiber.Map
cur int64
)
reportProgress := func() error {
if !req.ReportProgress {
Expand All @@ -507,10 +507,10 @@ func NewStreamArtifactsResponse(ctx *fiber.Ctx, rows *sql.Rows, runs map[string]
}
addImage := func(img models.Artifact, run models.Run) {
if runData == nil {
imagesPerStep := result.StepImageCount(img.RunID, 0)
imagesPerStep := result.StepImageCount(img.RunID, img.Name, 0)
runData = fiber.Map{
"ranges": fiber.Map{
"record_range_total": []int{0, result.TotalSteps(img.RunID)},
"record_range_total": []int{0, result.TotalSteps(img.RunID, img.Name)},
"record_range_used": []int{0, int(img.Step)},
"index_range_total": []int{0, imagesPerStep},
"index_range_used": []int{0, int(img.Index)},
Expand All @@ -532,23 +532,25 @@ func NewStreamArtifactsResponse(ctx *fiber.Ctx, rows *sql.Rows, runs map[string]
"active": run.Status == models.StatusRunning,
},
}
traces = map[string]fiber.Map{}
tracesMap = map[string]fiber.Map{}
}
trace, ok := traces[img.Name]
trace, ok := tracesMap[img.Name]
if !ok {
trace = fiber.Map{
"name": img.Name,
"context": fiber.Map{},
"caption": img.Caption,
"values": []fiber.Map{},
"iters": []fiber.Map{},
}
traces[img.Name] = trace
tracesMap[img.Name] = trace
}
traceValues, ok := trace["values"]
traceValues, ok := trace["values"].([]fiber.Map)
if !ok {
traceValues = []fiber.Map{}
}
iters, ok := trace["iters"].([]int64)
if !ok {
iters = []int64{}
}
value := fiber.Map{
"blob_uri": img.BlobURI,
"caption": img.Caption,
Expand All @@ -560,15 +562,25 @@ func NewStreamArtifactsResponse(ctx *fiber.Ctx, rows *sql.Rows, runs map[string]
"step": img.Step,
}
traceValues = append(traceValues, value)
iters = append(iters, img.Iter)
trace["values"] = traceValues
trace["iters"] = traceValues
trace["iters"] = iters
tracesMap[img.Name] = trace
}
setTraces := func(run fiber.Map) {

Check failure on line 570 in pkg/api/aim/api/response/run.go

View workflow job for this annotation

GitHub Actions / Go Lint

`NewStreamArtifactsResponse$1$1$3` - `run` is unused (unparam)
traces := make([]fiber.Map, len(tracesMap))
i := 0
for _, trace := range tracesMap {
traces[i] = trace
i++
}
runData["traces"] = traces
}
flushImages := func() error {
if runID == "" {
return nil
}
runData["traces"]["values"] = traceValues

setTraces(runData)
if err := encoding.EncodeTree(w, fiber.Map{
runID: runData,
}); err != nil {
Expand All @@ -593,7 +605,6 @@ func NewStreamArtifactsResponse(ctx *fiber.Ctx, rows *sql.Rows, runs map[string]
}
runID = image.RunID
runData = nil
traces = nil
}
addImage(image, runs[image.RunID])

Expand Down

0 comments on commit 7ff1133

Please sign in to comment.