Skip to content

Commit

Permalink
Adjust to endpoint implementation, add elementary test
Browse files Browse the repository at this point in the history
  • Loading branch information
suprjinx committed Jul 2, 2024
1 parent 6aaa481 commit 267d86b
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 6 deletions.
3 changes: 1 addition & 2 deletions docs/example/minimal_fasttrackml.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import time
from random import randint, random

from fasttrackml.entities.metric import Metric

import fasttrackml
from fasttrackml import FasttrackmlClient
from fasttrackml.entities.metric import Metric


def print_metric_info(history):
Expand Down
2 changes: 2 additions & 0 deletions pkg/api/mlflow/services/run/converters.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (

"github.com/G-Research/fasttrackml/pkg/api/mlflow/api/request"
"github.com/G-Research/fasttrackml/pkg/api/mlflow/dao/models"
"github.com/google/uuid"
)

// adjustSearchRunsRequestForNamespace preprocesses the SearchRunRequest for the given namespace.
Expand All @@ -29,6 +30,7 @@ func ConvertCreateRunArtifactRequestToModel(
namespaceID uint, req *request.LogArtifactRequest,
) *models.Artifact {
return &models.Artifact{
ID: uuid.New(),
Iter: req.Iter,
Step: req.Step,
RunID: req.RunID,
Expand Down
3 changes: 1 addition & 2 deletions python/client_example.py
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
import time
from random import randint, random

from fasttrackml.entities.metric import Metric

import fasttrackml
from fasttrackml import FasttrackmlClient
from fasttrackml.entities.metric import Metric


def print_metric_info(history):
Expand Down
10 changes: 9 additions & 1 deletion python/client_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
from random import random, uniform

import pytest
from fasttrackml.entities import Metric, Param

from fasttrackml import FasttrackmlClient
from fasttrackml.entities import Metric, Param

LOCALHOST = "127.0.0.1"

Expand Down Expand Up @@ -115,3 +115,11 @@ def test_init_output_logging(client, server, run):
for i in range(100):
log_data = str(uuid.uuid4()) + "\n" + str(uuid.uuid4())
print(log_data)


def test_log_image(client, server, run):
# test logging some images
for i in range(100):
assert (
client.log_image(run.info.run_id, "dice.png", "images", "These are dice", 0, 640, 480, "png", i, 0) == None
)
Binary file added python/dice.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion python/fasttrackml/store/custom_rest_store.py
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ def log_image(
"json": request_body,
}
)
if result.status_code != 200:
if result.status_code != 201:
result = result.json()
if "error_code" in result:
raise MlflowException(
Expand Down

0 comments on commit 267d86b

Please sign in to comment.