Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete overload and freeze when container is smaller than its largest box. #56

Open
RaphaelJuchs opened this issue May 23, 2017 · 0 comments

Comments

@RaphaelJuchs
Copy link

It gets stucks at the function _setBoxes();
As I said, It happens when the container is smaller than it's largest box, or when there's too much boxes for the plugin to make a correct layout of.

I just think it tries to find a right layout but simply can not with the given conditions.
It's annoying not because it doesn't work, but because it keeps trying to calculate, and completly overloads chrome and firefox: it even makes my other tab unresponsive.
You surely wouldn't want your website to do that to a user.

I'll try myself to add conditions to prevent calculating new layout if the conditions are too dangerous. I'm more WebDesigner than a developper, so it will probably won't be a very nice patch.

But other than that, it's an awesome plugin! Good work !
PS : You should consider adding a 'minHeight' property for the boxes. I added it myself in adding the parameter and changing 'minWidth' in 'minHeight' in all the y rules, and it worked !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant