feat: Sup 9265 perform a supervault test with a 5115 in between 4626s #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…supervault-test-with-a-5115-in-between-4626s
TamaraRingas
approved these changes
Nov 25, 2024
0xTimepunk
deleted the
sup-9265-perform-a-supervault-test-with-a-5115-in-between-4626s
branch
0xTimepunk
restored the
sup-9265-perform-a-supervault-test-with-a-5115-in-between-4626s
branch
gpersoon
reviewed
Nov 29, 2024
| superformContract = IBaseForm(superform); | ||
|
|
||
| vars.spBalances[i] = | ||
| ISuperPositions(_getAddress(keccak256("SUPER_POSITIONS"))).balanceOf(address(this), _superformIds_[i]); |
There was a problem hiding this comment.
_getAddress(keccak256("SUPER_POSITIONS"))) can be cached to improve readbility and safe gas
gpersoon
reviewed
Nov 29, 2024
|
|
||
| mvData.outputAmounts[i] = isERC5115 ? amountOut - TOLERANCE_CONSTANT : amountOut; | ||
|
|
||
| mvData.amounts[i] = superformContract.previewDepositTo(amountOut); |
There was a problem hiding this comment.
shouldn't this be the withdraw version? (previewWithdrawFrom()) ?
There was a problem hiding this comment.
Yearn tokenized strategies provide only "assets" and not shares when redeeming. So, first we have outputAmounts (which in Superform is the output "assets") . Then for it to interact with Superform core we must work back to shares, hence the reason for previewDepositTo
gpersoon
reviewed
Nov 29, 2024
| // For partial withdrawals, use proportional amounts | ||
| uint256 amountOut = amount_.mulDiv(weights[i], TOTAL_WEIGHT, Math.Rounding.Down); | ||
|
|
||
| mvData.outputAmounts[i] = isERC5115 ? amountOut - TOLERANCE_CONSTANT : amountOut; |
There was a problem hiding this comment.
perhaps have a function to adjust for the tolerance, for easier maintenance, something like:
function tolerance(bool isERC5115, uint256 amount) view returns (uint256){
return isERC5115 ? amount - TOLERANCE_CONSTANT : amount;
}
0xTimepunk
deleted the
sup-9265-perform-a-supervault-test-with-a-5115-in-between-4626s
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.