[SUBGRAPHS] Add goldsky subgraph tag script #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's no GHA to trigger this yet? |
kasparkallas
reviewed
Jul 1, 2024
| goldsky_commands=$(generate_goldsky_commands) | ||
| run_goldsky_commands_in_docker "$goldsky_commands" | ||
| elif [ -n "$network" ]; then | ||
| run_goldsky_commands_in_docker "if ! goldsky subgraph tag create $subgraph_type-$network/$version --tag prod; then |
There was a problem hiding this comment.
Let's make the "tag" an input as well? Then we can do "dev" and other adhoc versions.
|
In general, when it comes to tagging, one thing to keep in mind is not to do the tagging before the subgraph has finished indexing, i.e. it's caught up to the edge as Goldsky people put it. |
kasparkallas
approved these changes
Jul 4, 2024
hellwolf
approved these changes
Jul 4, 2024
XKCD Comic RelifLink: https://xkcd.com/1966 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a script that will be run manually to promote a new version of subgraph to prod.