[subgraph] configurable history pruning #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- limit the schema deps by what is available on goldsky currently
Changelog ReminderReminder to update the CHANGELOG.md for any of the modified packages in this PR.
|
kasparkallas
commented
Jun 11, 2024
| @@ -41,6 +52,7 @@ function main() { | |||
| nativeAssetSuperTokenAddress: networkMetadata.nativeTokenWrapper, | |||
| constantOutflowNFTAddress: networkMetadata.contractsV1.constantOutflowNFT || ADDRESS_ZERO, | |||
| constantInflowNFTAddress: networkMetadata.contractsV1.constantInflowNFT || ADDRESS_ZERO, | |||
| indexerHints_prune: vendorHistoryPruning[vendorName] || "never", | |||
There was a problem hiding this comment.
default to "never" (previous behavior)
d10r
approved these changes
Jun 11, 2024
XKCD Comic RelifLink: https://xkcd.com/1954 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
We want to index subgraphs to Goldsky with less entities created in the database.
How?
To do so, we will indroduce history pruning.
Other
Updated subgraph tooling and spec.
Warning!
If you rely on time-travel queries then this will be a breaking change. Contact us if you need continued access to time-travel queries!
Example of a time-travel query:
{ challenges(block: { number: 8000000 }) { challenger outcome application { id } } }Read more: