Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDESK-7487] Implement async /planning-locks endpoint #2207

Merged
merged 6 commits into from
Feb 18, 2025
Merged

[SDESK-7487] Implement async /planning-locks endpoint #2207

merged 6 commits into from
Feb 18, 2025

Conversation

eos87
Copy link

@eos87 eos87 commented Feb 14, 2025 •
edited by jira bot
Loading

Purpose

Convert the existing /planning_locks endpoint to async framework.

What has changed

  • Converted the /planning_locks endpoint to use async EndpointGroup
  • Updated the endpoint to use available async services (EventsAsyncService, PlanningAsyncService, and AssignmentsAsyncService) to query the list of locks.
  • Implemented concurrent async database queries to fetch locks.
  • Added necessary imports and refactored code to support async functionality.

Resolves: SDESK-7487

Thanks for checking!

eos87 added 3 commits February 14, 2025 15:22
@eos87
Implement /planning_locks endpoint with async framework
c339675 
SDESK-7487
@eos87
Complete async implementation of /planning_locks
c618d87 
SDESK-7487
@eos87
Replace get_app_config call with hardcoded 'api'
ffd195d 
Otherwise `get_app_config` will throw an exception because superdesk app is not yet running
@eos87 eos87 marked this pull request as ready for review February 14, 2025 17:14
@eos87 eos87 added the async label Feb 14, 2025
@eos87
Copy link
Author

eos87 commented Feb 14, 2025

This PR depends on superdesk/superdesk-core#2832

@eos87 eos87 changed the title Implement async /planning-locks endpoint [SDESK-7487] Implement async /planning-locks endpoint Feb 14, 2025
MarkLark86
MarkLark86 reviewed Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@MarkLark86 MarkLark86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple small things, otherwise looks good

@eos87 eos87 requested a review from MarkLark86 February 17, 2025 15:54
@eos87 eos87 merged commit 1207f02 into async Feb 18, 2025
10 of 20 checks passed
@eos87 eos87 deleted the hg/SDESK-7487-planning-locks branch February 18, 2025 09:14
@MarkLark86 MarkLark86 added this to the 3.0 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrianMwangi21 BrianMwangi21 BrianMwangi21 approved these changes

@MarkLark86 MarkLark86 MarkLark86 approved these changes

Assignees
No one assigned
Labels
async
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eos87 @BrianMwangi21 @MarkLark86