Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor websockets handling #2836

Merged
merged 2 commits into from
Feb 20, 2025
Merged

refactor websockets handling #2836

merged 2 commits into from
Feb 20, 2025

Conversation

petrjasek
Copy link
Member

  • drop unused server loop
  • drop pings (it's handled via websockets library)
  • setup sentry_sdk

SDCP-879

@petrjasek
refactor websockets handling
70016fa 
- drop unused server loop
- drop pings (it's handled via websockets library)
- setup sentry_sdk

SDCP-879
@petrjasek petrjasek added this to the v2.9 milestone Feb 19, 2025
MarkLark86
MarkLark86 approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@MarkLark86 MarkLark86 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine to me, though I guess this is something that just needs to be tested rather than peer reviewed.

Does the newer sentry-sdk version work with our version of Sentry v9.0, or would we need to update that too?

@petrjasek
Copy link
Member Author

it does not, already talked with infra about that, there will be a new instance with up to date version

@petrjasek petrjasek merged commit 6ba1d71 into superdesk:develop Feb 20, 2025
15 checks passed
@petrjasek petrjasek deleted the chore-bump-websockets-sentry branch February 20, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLark86 MarkLark86 Awaiting requested review from MarkLark86

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.9
Development

Successfully merging this pull request may close these issues.
2 participants
@petrjasek @MarkLark86