Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDESK-7487] Add docstrings about usage of url in endpoints #2832

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

eos87
Copy link

@eos87 eos87 commented Feb 14, 2025

Purpose

- Fix a bug that the url_prefix was not being added to the endpoint urls even when it was provided to the EndpointGroup definition.

Update: I have found what was the problem on my local not picking up the the url prefix and api version. I turned this PR into just adding some docstrings regarding the usage of the url_prefix when registering an endpoint.

SDESK-7487

The `url_prefix` was not being added to the endpoints when it was provided

SDESK-7487
And remove not needed changed introduced initially
@eos87 eos87 changed the title [SDESK-7487] Fix url_prefix not being added to endpoints in a group [SDESK-7487] Add docstrings about usage of url in endpoints Feb 17, 2025
@eos87 eos87 requested a review from BrianMwangi21 February 17, 2025 15:41
@eos87 eos87 merged commit fb68e12 into async Feb 18, 2025
19 of 31 checks passed
@eos87 eos87 deleted the hg/SDESK-7487-planning-locks branch February 18, 2025 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants