[PUBLISH]Cache Formatter.format result when suitable.
#2757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Enqueue Service, `Formatter.format` result is now cached when `subscriber` (e.g. for `publish_seq_num`) or `codes` is not used in the formatted item. SDESK-7449
MarkLark86
approved these changes
Dec 11, 2024
|
@MarkLark86 What about the failing tests? Are they expected to fail at this point? For a quick glance they don't look related to my changes. |
Pytest is passing, I got that working last week. I'll be working on getting other tests to pass later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Enqueue Service,
Formatter.formatresult is now cached whensubscriber(e.g. forpublish_seq_num) orcodesis not used in the formatted item.SDESK-7449