fix: apollo account endpoint and docs (#1743)

- Restore creating/updating apollo accounts (but not GET) - Add documentation to clarify supported feature matrix ## Test Plan [Describe test plan here] ## Deployment instructions [Add any special deployment instructions here]
supaglue-labs · Oct 18, 2023 · 5450b03 · 5450b03 · vercel · Oct 18, 2023
1 parent b4d23bf
commit 5450b03
Show file tree

Hide file tree

Showing 7 changed files with 48 additions and 10 deletions.
diff --git a/docs/docs/api/v2/engagement/get-account.api.mdx b/docs/docs/api/v2/engagement/get-account.api.mdx
diff --git a/docs/docs/providers/apollo.md b/docs/docs/providers/apollo.md
@@ -28,6 +28,7 @@ Apollo is both a sales engagement connector and a data enrichment provider.
 | Object          | Soft delete supported | Sync strategy |
 | --------------- | --------------------- | ------------- |
 | Users           | Yes                   | Full          |
+| Accounts        | Yes                   | Full          |
 | Contacts        | Yes                   | Full          |
 | Sequences       | Yes                   | Full          |
 | Sequence States | Yes                   | Full          |

diff --git a/docs/docs/providers/gong.md b/docs/docs/providers/gong.md
@@ -31,10 +31,12 @@ N/A
 
 | Object           | Soft delete supported | Sync strategy       |
 | ---------------- | --------------------- | ------------------- |
-| `call`           | No (Yes if "Full")    | Full or Incremental |
-| `detailedCall`   | No (Yes if "Full")    | Full or Incremental |
+| `call`           | No\*                  | Full or Incremental |
+| `detailedCall`   | No\*                  | Full or Incremental |
 | `callTranscript` | Yes                   | Full                |
 
+[*] Soft deletes are supported if the sync strategy is "Full"
+
 #### Supported custom objects:
 
 N/A

diff --git a/openapi/v2/engagement/openapi.bundle.json b/openapi/v2/engagement/openapi.bundle.json
diff --git a/openapi/v2/engagement/paths/accounts@{account_id}.yaml b/openapi/v2/engagement/paths/accounts@{account_id}.yaml
@@ -1,6 +1,14 @@
 get:
   operationId: getAccount
   summary: Get account
+  description: |
+    Support:
+
+    | Provider   | Supported | 
+    | ---------- | --------- | 
+    | Salesloft  | Yes       | 
+    | Outreach   | Yes       | 
+    | Apollo     | No        |
   tags:
     - Accounts
   security:

diff --git a/packages/core/remotes/impl/apollo/index.ts b/packages/core/remotes/impl/apollo/index.ts
@@ -411,7 +411,8 @@ class ApolloClient extends AbstractEngagementRemoteClient {
         )) as CreateCommonObjectRecordResponse<T>;
       case 'contact':
         return (await this.createContact(params as ContactCreateParams)) as CreateCommonObjectRecordResponse<T>;
-      case 'account': // return (await this.createAccount(params as AccountCreateParams)) as CreateCommonObjectRecordResponse<T>;
+      case 'account':
+        return (await this.createAccount(params as AccountCreateParams)) as CreateCommonObjectRecordResponse<T>;
       case 'sequence':
       case 'mailbox':
       case 'user':
@@ -427,8 +428,8 @@ class ApolloClient extends AbstractEngagementRemoteClient {
   ): Promise<UpdateCommonObjectRecordResponse<T>> {
     // TODO: figure out why type assertion is required here
     switch (commonObjectType) {
-      // case 'account':
-      //   return (await this.updateAccount(params as AccountUpdateParams)) as UpdateCommonObjectRecordResponse<T>;
+      case 'account':
+        return (await this.updateAccount(params as AccountUpdateParams)) as UpdateCommonObjectRecordResponse<T>;
       case 'contact':
         return (await this.updateContact(params as ContactUpdateParams)) as UpdateCommonObjectRecordResponse<T>;
       default:

diff --git a/packages/schemas/gen/v2/engagement.ts b/packages/schemas/gen/v2/engagement.ts