Include Source Sans 3 #2322
Merged
Include Source Sans 3 #2322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
use-source-sans
branch
2 times, most recently
from
08bbb73 to
d7a9816
Compare
| @@ -5,6 +5,8 @@ | |||
| @import "modules/popup_panels"; | |||
| @import "modules/utility"; | |||
|
|
|||
| @import "https://fonts.googleapis.com/css2?family=Source+Sans+3:ital,wght@0,200..900;1,200..900&display=swap"; | |||
There was a problem hiding this comment.
Do we use all these weights? Might be able to save a few kB if it's only 300,400,700 which are more common
There was a problem hiding this comment.
I was using the same URL as in the component-library, so that the user will have a cached version.
There was a problem hiding this comment.
Interesting. I guess if we get people to cache them all across our sites, it'll matter less
Previously we were using Source Sans Pro, which was not included in the styles
jcoyne
force-pushed
the
use-source-sans
branch
from
d7a9816 to
644b2eb
Compare
thatbudakguy
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using Source Sans Pro, which was not included in the styles