-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy content to clipboard for share modal #1833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-collier
force-pushed
the
t1780-copy-to-clipboard
branch
from
November 28, 2023 00:53
a9fa0aa
to
30ccb19
Compare
aaron-collier
changed the title
[DRAFT] Use basic javascript to copy content to clipboard
Add copy content to clipboard for share modal
Nov 28, 2023
aaron-collier
force-pushed
the
t1780-copy-to-clipboard
branch
from
November 28, 2023 16:47
d34ed36
to
9759a56
Compare
jcoyne
requested changes
Nov 28, 2023
aaron-collier
force-pushed
the
t1780-copy-to-clipboard
branch
from
November 28, 2023 17:24
9759a56
to
646d996
Compare
jcoyne
reviewed
Nov 28, 2023
aaron-collier
force-pushed
the
t1780-copy-to-clipboard
branch
from
November 28, 2023 17:30
646d996
to
1919175
Compare
aaron-collier
force-pushed
the
t1780-copy-to-clipboard
branch
from
November 28, 2023 17:53
1919175
to
f2e2d8f
Compare
jcoyne
requested changes
Nov 28, 2023
aaron-collier
force-pushed
the
t1780-copy-to-clipboard
branch
2 times, most recently
from
November 28, 2023 18:09
8d5f639
to
bb3b3ee
Compare
jcoyne
requested changes
Nov 28, 2023
Add aria-labels to buttons Update tests to include button verification
aaron-collier
force-pushed
the
t1780-copy-to-clipboard
branch
from
November 28, 2023 18:30
bb3b3ee
to
aaeb463
Compare
jcoyne
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1780