Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy content to clipboard for share modal #1833

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

aaron-collier
Copy link
Contributor

@aaron-collier aaron-collier commented Nov 27, 2023

Closes #1780

Screenshot 2023-11-27 at 2 19 25 PM

@aaron-collier aaron-collier force-pushed the t1780-copy-to-clipboard branch from a9fa0aa to 30ccb19 Compare November 28, 2023 00:53
@aaron-collier aaron-collier changed the title [DRAFT] Use basic javascript to copy content to clipboard Add copy content to clipboard for share modal Nov 28, 2023
@aaron-collier aaron-collier force-pushed the t1780-copy-to-clipboard branch from d34ed36 to 9759a56 Compare November 28, 2023 16:47
@aaron-collier aaron-collier marked this pull request as ready for review November 28, 2023 16:49
app/assets/stylesheets/media.scss Outdated Show resolved Hide resolved
app/assets/stylesheets/media.scss Outdated Show resolved Hide resolved
@aaron-collier aaron-collier force-pushed the t1780-copy-to-clipboard branch from 9759a56 to 646d996 Compare November 28, 2023 17:24
@aaron-collier aaron-collier force-pushed the t1780-copy-to-clipboard branch from 646d996 to 1919175 Compare November 28, 2023 17:30
@aaron-collier aaron-collier marked this pull request as draft November 28, 2023 17:31
@aaron-collier aaron-collier force-pushed the t1780-copy-to-clipboard branch from 1919175 to f2e2d8f Compare November 28, 2023 17:53
@aaron-collier aaron-collier marked this pull request as ready for review November 28, 2023 17:54
app/assets/stylesheets/media.scss Outdated Show resolved Hide resolved
@aaron-collier aaron-collier force-pushed the t1780-copy-to-clipboard branch 2 times, most recently from 8d5f639 to bb3b3ee Compare November 28, 2023 18:09
Add aria-labels to buttons

Update tests to include button verification
@aaron-collier aaron-collier force-pushed the t1780-copy-to-clipboard branch from bb3b3ee to aaeb463 Compare November 28, 2023 18:30
@jcoyne jcoyne merged commit 976ccff into main Nov 28, 2023
1 check passed
@jcoyne jcoyne deleted the t1780-copy-to-clipboard branch November 28, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "copy to clipboard" buttons to the share modal
2 participants