Add BCP 47 resolution #1799
Merged
Add BCP 47 resolution #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjgiarlo
force-pushed
the
bcp47-resolution
branch
3 times, most recently
from
b0da12d to
b669d9d
Compare
mjgiarlo
commented
Nov 22, 2023
Comment on lines
+3
to
+16
| module Bcp47 | ||
| require 'bcp47/parser' | ||
| require 'bcp47/record' | ||
| require 'bcp47/registry' | ||
| end |
There was a problem hiding this comment.
Sticking this in lib/ since it seems ripe for extraction to a new BCP 47 gem. The current gems for BCP 47 are outdated and unmaintained, as best I can tell.
mjgiarlo
force-pushed
the
bcp47-resolution
branch
from
b669d9d to
c35902f
Compare
jcoyne
requested changes
Nov 22, 2023
mjgiarlo
force-pushed
the
bcp47-resolution
branch
2 times, most recently
from
b8d2b3d to
4de8edc
Compare
mjgiarlo
force-pushed
the
bcp47-resolution
branch
from
4de8edc to
956ad32
Compare
This commit adds the ability to parse BCP 47 registries into records and look up labels given BCP 47 tag strings.
mjgiarlo
force-pushed
the
bcp47-resolution
branch
from
956ad32 to
c2d75ec
Compare
|
Needs a rebase. |
@jcoyne done, thanks! |
jcoyne
requested changes
Nov 29, 2023
mjgiarlo
force-pushed
the
bcp47-resolution
branch
from
8595a91 to
31d19ec
Compare
jcoyne
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to parse BCP 47 registries into records and look up labels given BCP 47 tag strings.