Decouple ResourceFile from Resource #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
pass-druid
branch
2 times, most recently
from
b88bd86 to
02224aa
Compare
jcoyne
changed the title
ResourceFile no longer needs to know about the internals of Resource
mjgiarlo
reviewed
Nov 17, 2023
| @@ -3,21 +3,22 @@ | |||
| module Embed | |||
| class Purl | |||
| class ResourceFile | |||
| # @param [Embed::Purl::Resource] resource | |||
| # @param [String] druid the identifier of the resource this file belongs to. | |||
| # @param [String] description the label for this file | |||
There was a problem hiding this comment.
Should we consider calling this label?
There was a problem hiding this comment.
I'll get to that in the next PR.
mjgiarlo
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to decouple the file from the resource