Style caption settings for better usability #1764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-collier
force-pushed
the
t1498-style-caption-settings
branch
from
f035cfc to
c98e875
Compare
aaron-collier
changed the title
jcoyne
approved these changes
Nov 17, 2023
jcoyne
reviewed
Nov 17, 2023
aaron-collier
force-pushed
the
t1498-style-caption-settings
branch
from
c98e875 to
767f254
Compare
mjgiarlo
reviewed
Nov 17, 2023
aaron-collier
force-pushed
the
t1498-style-caption-settings
branch
from
767f254 to
290a8f8
Compare
mjgiarlo
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1498
This is a first step in applying the design for the caption settings dialog. This cleans up the existing dialog so that it is usable, a future PR will be necessary IF the design can be made applicable to the provided videojs html.