Aria label for download must include count displayed in viewer #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
requested changes
Nov 17, 2023
aaron-collier
force-pushed
the
t1723-update-aria-label-for-download-link
branch
2 times, most recently
from
045fc22 to
26140eb
Compare
aaron-collier
force-pushed
the
t1723-update-aria-label-for-download-link
branch
from
26140eb to
8ff636f
Compare
jcoyne
requested changes
Nov 17, 2023
jcoyne
reviewed
Nov 17, 2023
aaron-collier
force-pushed
the
t1723-update-aria-label-for-download-link
branch
from
7a81b62 to
a10f721
Compare
mjgiarlo
approved these changes
Nov 20, 2023
|
@jcoyne Have another look? |
jcoyne
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1723