Remove object_thumbnail? method #1749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
remove-object-thumbnail
branch
3 times, most recently
from
2cdaefe to
0896da6
Compare
jcoyne
force-pushed
the
remove-object-thumbnail
branch
from
0896da6 to
6e3f680
Compare
SDR never makes metadata with the thumb attribute anymore. This method would return false for every object
jcoyne
force-pushed
the
remove-object-thumbnail
branch
from
6e3f680 to
0e8cb3e
Compare
mjgiarlo
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDR never makes metadata with the thumb attribute anymore. This method would return false for every object
There were only 7 remaining objects that had this resource type. Andrew remediatied these: