Skip to content

Commit

Permalink
Merge pull request #1713 from sul-dlss/t1688-media-content-tab-roles
Browse files Browse the repository at this point in the history
Set appropriate aria-role, aria-selected, and aria-controls for the content thumbnails
  • Loading branch information
jcoyne authored Nov 9, 2023
2 parents 87cac54 + e99a5e6 commit 214c0df
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
<h3>Media Content</h3>
</div>

<ul class="contentsList" data-media-tag-target="list"></ul>
<ul class="contentsList" data-media-tag-target="list" role="tablist"></ul>
</section>
<section id="rights" data-media-target="rights" role="tabpanel" hidden>
<div class="header-background">
Expand All @@ -87,7 +87,7 @@
</section>
</div>
</aside>
<div class='sul-embed-body sul-embed-media'>
<div class='sul-embed-body sul-embed-media' id='sul-embed-body'>
<%= render Embed::MediaTagComponent.with_collection(resources_with_primary_file,
include_transcripts:,
druid:,
Expand Down
10 changes: 10 additions & 0 deletions app/javascript/src/controllers/thumbnail_controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,15 @@ export default class extends Controller {
evt.preventDefault();
const event = new CustomEvent('thumbnail-clicked', { detail: { index: evt.params.index } })
window.dispatchEvent(event)

const tabs = this.element.closest('[role="tablist"]').querySelectorAll('[role="tab"]')
tabs.forEach((target) => {
target.classList.remove('active')
target.setAttribute("aria-selected", false)
})

const target = this.element
target.classList.add('active')
target.setAttribute("aria-selected", true)
}
}
2 changes: 1 addition & 1 deletion app/javascript/src/modules/media_thumbnail_builder.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default function(dataset, index) {
const fileLabel = dataset.fileLabel || '';
const duration = dataset.duration || '';
// Note: the "position: relative" is required for the stretched-link style.
return `<li class="sul-embed-media-slider-thumb ${activeClass}" data-controller="thumbnail" data-action="click->thumbnail#activate" data-thumbnail-index-param="${index}" style="position: relative;">
return `<li class="sul-embed-media-slider-thumb ${activeClass}" data-controller="thumbnail" data-action="click->thumbnail#activate" data-thumbnail-index-param="${index}" style="position: relative;" aria-controls="sul-embed-body" role="tab">
<a class="sul-embed-stretched-link" href="#">
${thumbnailIcon}
<span class="${labelClass}">
Expand Down

0 comments on commit 214c0df

Please sign in to comment.