Mocked AWS & Github Action #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsu
commented
Oct 28, 2024
| @@ -345,6 +331,14 @@ def load_whisper_model(model_name): | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
| dotenv.load_dotenv() | |||
There was a problem hiding this comment.
the loading of the dotenv file was moved here so that it doesn't interfere with unit testing, which overrides the runtime environment
edsu
commented
Oct 28, 2024
| @pytest.fixture(scope="function") | ||
| def queues(sqs): | ||
| sqs.create_queue(QueueName=TODO_QUEUE) | ||
| sqs.create_queue(QueueName=DONE_QUEUE) |
There was a problem hiding this comment.
All of the above is for mocking out STS, SQS and S3 services with moto. moto allows these mocked out services to operate as if they were actually running, but with fake local resources.
edsu
commented
Oct 28, 2024
|
|
||
| bucket = speech_to_text.get_bucket() | ||
| for obj in bucket.objects.all(): | ||
| obj.delete() |
There was a problem hiding this comment.
Since we aren't using AWS live anymore, and moto resources are temporary, this cleanup can go away.
edsu
force-pushed
the
github-action
branch
2 times, most recently
from
d887601 to
7aeb806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mocks AWS resources in the test with moto. It also includes a Github Action configuration to run linting and format check with ruff, before running the tests.
Closes #12
Refs #36