Merge pull request #4896 from sul-dlss/fix-remove-release-tags-migrator

Make RemoveReleaseTags migrator a little smarter

app/services/migrators/remove_release_tags.rb

@@ -4,7 +4,9 @@ module Migrators
   # Migrator that will be used to remove release tags.
   class RemoveReleaseTags < Base
     def migrate?
-      (ar_cocina_object.is_a?(Dro) || ar_cocina_object.is_a?(Collection)) && ar_cocina_object.administrative.key?('releaseTags')
+      (ar_cocina_object.is_a?(Dro) || ar_cocina_object.is_a?(Collection)) &&
+        ar_cocina_object.administrative.key?('releaseTags') &&
+        ar_cocina_object.administrative.fetch('releaseTags').present?
     end
 
     def migrate

spec/services/migrators/remove_release_tags_spec.rb

@@ -6,22 +6,45 @@
   subject(:migrator) { described_class.new(ar_cocina_object) }
 
   let(:ar_cocina_object) { create(:ar_dro) }
+  let(:tags) do
+    [
+      {
+        who: 'mjg',
+        what: 'self',
+        date: '2021-12-28T00:09:00.000+00:00',
+        to: 'Earthworks',
+        release: true
+      }
+    ]
+  end
 
   describe '#migrate?' do
     subject { migrator.migrate? }
 
-    context 'when a dro' do
-      let(:ar_cocina_object) { create(:ar_dro, administrative: { hasAdminPolicy: 'druid:hy787xj5878', releaseTags: [] }) }
+    context 'when a dro with tags' do
+      let(:ar_cocina_object) { create(:ar_dro, administrative: { hasAdminPolicy: 'druid:hy787xj5878', releaseTags: tags }) }
 
       it { is_expected.to be true }
     end
 
-    context 'when a collection' do
-      let(:ar_cocina_object) { create(:ar_collection, administrative: { hasAdminPolicy: 'druid:hy787xj5878', releaseTags: [] }) }
+    context 'when a collection with tags' do
+      let(:ar_cocina_object) { create(:ar_collection, administrative: { hasAdminPolicy: 'druid:hy787xj5878', releaseTags: tags }) }
 
       it { is_expected.to be true }
     end
 
+    context 'when a dro without tags' do
+      let(:ar_cocina_object) { create(:ar_dro, administrative: { hasAdminPolicy: 'druid:hy787xj5878', releaseTags: [] }) }
+
+      it { is_expected.to be false }
+    end
+
+    context 'when a collection without tags' do
+      let(:ar_cocina_object) { create(:ar_collection, administrative: { hasAdminPolicy: 'druid:hy787xj5878', releaseTags: [] }) }
+
+      it { is_expected.to be false }
+    end
+
     context 'when an APO' do
       let(:ar_cocina_object) { create(:ar_admin_policy) }