Return version description with version status.

refs sul-dlss/hungry-hungry-hippo#704
sul-dlss · Feb 13, 2025 · 29e1edc · 29e1edc
1 parent 960040c
commit 29e1edc
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 6 deletions.
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -87,8 +87,6 @@ GEM
     attr_extras (7.1.0)
     base64 (0.2.0)
     bcrypt_pbkdf (1.1.1)
-    bcrypt_pbkdf (1.1.1-arm64-darwin)
-    bcrypt_pbkdf (1.1.1-x86_64-darwin)
     benchmark (0.4.0)
     bigdecimal (3.1.9)
     bootsnap (1.18.4)

diff --git a/app/controllers/versions_controller.rb b/app/controllers/versions_controller.rb
@@ -141,6 +141,8 @@ def load_repository_object_version
   def status_for(druid:, version:)
     version_service = VersionService.new(druid:, version:)
     workflow_state_service = WorkflowStateService.new(druid:, version:)
+    repository_object = RepositoryObject.find_by!(external_identifier: druid)
+    version_description = repository_object.versions.select(:version_description).find_by!(version:).version_description
 
     {
       versionId: version,
@@ -149,7 +151,8 @@ def status_for(druid:, version:)
       assembling: workflow_state_service.assembling?,
       accessioning: workflow_state_service.accessioning?,
       closeable: version_service.can_close?,
-      discardable: version_service.can_discard?
+      discardable: version_service.can_discard?,
+      versionDescription: version_description
     }
   end
 end
diff --git a/openapi.yml b/openapi.yml
@@ -3395,6 +3395,7 @@ components:
         - accessioning
         - closeable
         - discardable
+        - versionDescription
       properties:
         versionId:
           type: integer
@@ -3414,6 +3415,9 @@ components:
         closeable:
           type: boolean
           description: whether the version can be closed
+        versionDescription:
+          type: string
+          description: a message that explains what changed
     BackgroundJobResultResponse:
       type: object
       properties:

diff --git a/spec/requests/versions_spec.rb b/spec/requests/versions_spec.rb
@@ -193,6 +193,7 @@
     before do
       allow(VersionService).to receive(:new).and_return(version_service)
       allow(WorkflowStateService).to receive(:new).and_return(workflow_state_service)
+      create(:repository_object_version, :with_repository_object, external_identifier: druid, version: 1)
     end
 
     it 'returns the version status for an object' do
@@ -206,7 +207,8 @@
                                                                       assembling: true,
                                                                       accessioning: false,
                                                                       closeable: true,
-                                                                      discardable: true
+                                                                      discardable: true,
+                                                                      versionDescription: 'Best version ever'
                                                                     })
     end
   end
@@ -219,6 +221,8 @@
     let(:workflow_state_service2) { instance_double(WorkflowStateService, assembling?: false, accessioning?: true) }
 
     before do
+      create(:repository_object_version, :with_repository_object, external_identifier: druids[0], version: 1)
+      create(:repository_object_version, :with_repository_object, external_identifier: druids[1], version: 2)
       allow(CocinaObjectStore).to receive(:version).with(druids[0]).and_return(1)
       allow(CocinaObjectStore).to receive(:version).with(druids[1]).and_return(2)
       allow(CocinaObjectStore).to receive(:version).with(druids[2]).and_raise(CocinaObjectStore::CocinaObjectNotFoundError)
@@ -241,7 +245,8 @@
                                                                       assembling: true,
                                                                       accessioning: false,
                                                                       closeable: true,
-                                                                      discardable: true
+                                                                      discardable: true,
+                                                                      versionDescription: 'Best version ever'
                                                                     },
                                                                     'druid:fp165nz4391' => {
                                                                       versionId: 2,
@@ -250,7 +255,8 @@
                                                                       assembling: false,
                                                                       accessioning: true,
                                                                       closeable: false,
-                                                                      discardable: false
+                                                                      discardable: false,
+                                                                      versionDescription: 'Best version ever'
                                                                     })
     end
   end