This repository has been archived by the owner on Jan 8, 2022. It is now read-only.
tell carrierwave to use move instead of copy during uploads #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peetucket
force-pushed
the
use-move-instead-of-copy-for-uploads
branch
from
d169d36 to
413095d
Compare
peetucket
force-pushed
the
use-move-instead-of-copy-for-uploads
branch
from
413095d to
9be4790
Compare
peetucket
changed the title
jcoyne
reviewed
Sep 19, 2017
| @@ -18,6 +18,19 @@ class FileUploader < CarrierWave::Uploader::Base | |||
| before :store, :remember_cache_id | |||
| after :store, :delete_tmp_dir | |||
|
|
|||
| ## | |||
| # By default, CarrierWave copies an uploaded file twice, first copying the file into the cache, then copying the file into the store. | |||
| # For large files, this can be prohibitively time consuming. | |||
There was a problem hiding this comment.
What's the reason for doing this? Are we seeing this as an issue? Are these directories on the same file system?
There was a problem hiding this comment.
There are occasional issues where a very big file fails to upload correctly and/or where the tmp space fills up. Thought this could potentially help those scenarios by avoiding a seemingly unnecessary big file copy, but I don't have data to back that up.
|
can this be closed and the branch removed? it's over 2 years old. |
|
After some discussion with @peetucket, I propose we pick this work back up rather than dispose of it, assuming that it doesn't require much time to complete. Users, and SDR service team members, would benefit from this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #391
see https://github.com/carrierwaveuploader/carrierwave#large-files