Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(audit): lt #338

Merged
merged 8 commits into from
Feb 3, 2024
Merged

fix(audit): lt #338

merged 8 commits into from
Feb 3, 2024

Conversation

ratankaliani
Copy link
Member

@ratankaliani ratankaliani commented Jan 24, 2024

Correctly constrain lt. Previously, if the RHS of lt was 0, the subtraction would cause the RHS to wrap around to become the largest value, which would cause lt & gt to return the wrong value.

Switch lt to instead use lte, as lt(a,b) = !lte(b, a).

Base: tamir/audit_fixes.

@ratankaliani ratankaliani changed the base branch from main to tamir/audit_fixes January 24, 2024 20:46
@ratankaliani ratankaliani changed the title fix: lt fix(audit): lt Jan 28, 2024
@puma314 puma314 merged commit 3b8ba82 into tamir/audit_fixes Feb 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants