Add Attributes for Tests

subugoe · Jan 6, 2025 · 9b50292 · 9b50292
1 parent 71853f0
commit 9b50292
Show file tree

Hide file tree

Showing 10 changed files with 44 additions and 84 deletions.
diff --git a/Tests/Unit/Controller/SearchControllerTest.php b/Tests/Unit/Controller/SearchControllerTest.php
@@ -27,6 +27,8 @@
  *  This copyright notice MUST APPEAR in all copies of the script!
  * ************************************************************* */
 
+use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
+use PHPUnit\Framework\Attributes\Test;
 use Subugoe\Find\Controller\SearchController;
 use TYPO3\TestingFramework\Core\BaseTestCase;
 
@@ -47,11 +49,8 @@ protected function setUp(): void
             ->getMock();
     }
 
-    /**
-     * @test
-     *
-     * @doesNotPerformAssertions
-     */
+    #[Test]
+    #[DoesNotPerformAssertions]
     public function implementTests(): void
     {
         self::markTestIncomplete();

diff --git a/Tests/Unit/Service/SolrServiceProviderTest.php b/Tests/Unit/Service/SolrServiceProviderTest.php
@@ -27,6 +27,7 @@
  *  This copyright notice MUST APPEAR in all copies of the script!
  * ************************************************************* */
 
+use PHPUnit\Framework\Attributes\Test;
 use Subugoe\Find\Service\SolrServiceProvider;
 use TYPO3\TestingFramework\Core\BaseTestCase;
 
@@ -42,15 +43,10 @@ class SolrServiceProviderTest extends BaseTestCase
 
     protected function setUp(): void
     {
-        $this->fixture = $this->getMockBuilder(SolrServiceProvider::class)
-            ->addMethods(['dummy'])
-            ->disableOriginalConstructor()
-            ->getMock();
+        $this->fixture = $this->getAccessibleMock(SolrServiceProvider::class, null, callOriginalConstructor: false);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function setConfigurationAddsTheValueToConfigurationArray()
     {
         $key = 'foo';
@@ -60,9 +56,7 @@ public function setConfigurationAddsTheValueToConfigurationArray()
         self::assertArrayHasKey($key, $this->fixture->getConfiguration());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function setConfigurationAddsAKeyValuePairToAnExistingConfiguration()
     {
         $key = 'foo';

diff --git a/Tests/Unit/Utility/UpgradeUtilityTest.php b/Tests/Unit/Utility/UpgradeUtilityTest.php
@@ -4,12 +4,14 @@
 
 namespace Subugoe\Find\Tests\Unit\Utility;
 
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\Test;
 use Subugoe\Find\Utility\UpgradeUtility;
 use TYPO3\TestingFramework\Core\BaseTestCase;
 
 class UpgradeUtilityTest extends BaseTestCase
 {
-    public function settingsProvider(): array
+    public static function settingsProvider(): array
     {
         return [
             [
@@ -61,11 +63,8 @@ public function settingsProvider(): array
         ];
     }
 
-    /**
-     * @test
-     *
-     * @dataProvider settingsProvider
-     */
+    #[DataProvider('settingsProvider')]
+    #[Test]
     public function configurationIsAutomaticallyUpgraded(array $settings, $expected): void
     {
         self::assertSame($expected, UpgradeUtility::handleSolariumUpgrade($settings));

diff --git a/Tests/Unit/ViewHelpers/Data/NewArrayViewHelperTest.php b/Tests/Unit/ViewHelpers/Data/NewArrayViewHelperTest.php
@@ -26,6 +26,7 @@
  *  This copyright notice MUST APPEAR in all copies of the script!
  * ************************************************************* */
 
+use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\MockObject\MockObject;
 use Subugoe\Find\ViewHelpers\Data\NewArrayViewHelper;
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
@@ -48,9 +49,7 @@ protected function setUp(): void
         $this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function aNewArrayFromArgumentsIsCorrectlyCreated(): void
     {
         $arguments = [
@@ -70,9 +69,7 @@ public function aNewArrayFromArgumentsIsCorrectlyCreated(): void
         self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function aNewArrayWithoutAnExistingOneIsCreated(): void
     {
         $arguments = [
@@ -90,9 +87,7 @@ public function aNewArrayWithoutAnExistingOneIsCreated(): void
         self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function aNewArrayWithMultipleEntriesIsCreated(): void
     {
         $arguments = [
@@ -111,9 +106,7 @@ public function aNewArrayWithMultipleEntriesIsCreated(): void
         self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function emptyStringsAsArrayKeysAreConsideredAsKeysAndValues(): void
     {
         $arguments = [

diff --git a/Tests/Unit/ViewHelpers/Data/SplitViewHelperTest.php b/Tests/Unit/ViewHelpers/Data/SplitViewHelperTest.php
@@ -26,6 +26,7 @@
  *  This copyright notice MUST APPEAR in all copies of the script!
  * ************************************************************* */
 
+use PHPUnit\Framework\Attributes\Test;
 use Subugoe\Find\ViewHelpers\Data\SplitViewHelper;
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
 use TYPO3\TestingFramework\Core\BaseTestCase;
@@ -48,9 +49,7 @@ protected function setUp(): void
         $this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function stringIsExplodedCorrectlyWithoutPassedSeparator()
     {
         $string = 'hrdr, behedeti, horus';
@@ -64,9 +63,7 @@ public function stringIsExplodedCorrectlyWithoutPassedSeparator()
         self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function stringIsExplodedCorrectlyWithPassedSeparator()
     {
         $string = 'hrdr, behedeti, horus';
@@ -81,9 +78,7 @@ public function stringIsExplodedCorrectlyWithPassedSeparator()
         self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function stringIsExplodedCorrectlyWithNonDefaultSeparator()
     {
         $string = 'hrdrhorus behedetihorus horus';
@@ -97,9 +92,7 @@ public function stringIsExplodedCorrectlyWithNonDefaultSeparator()
         self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function emptyArrayIsReturnedWhenPassingIt()
     {
         $string = '';

diff --git a/Tests/Unit/ViewHelpers/Data/ValueForKeyViewHelperTest.php b/Tests/Unit/ViewHelpers/Data/ValueForKeyViewHelperTest.php
@@ -26,6 +26,7 @@
  *  This copyright notice MUST APPEAR in all copies of the script!
  * ************************************************************* */
 
+use PHPUnit\Framework\Attributes\Test;
 use Subugoe\Find\Tests\Unit\ViewHelpers\MockRenderingContextTrait;
 use Subugoe\Find\ViewHelpers\Data\ValueForKeyViewHelper;
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
@@ -51,9 +52,7 @@ protected function setUp(): void
         $this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function keyPicksTheRightValueFromTheArray()
     {
         $array = [
@@ -70,9 +69,7 @@ public function keyPicksTheRightValueFromTheArray()
         self::assertSame('b', $this->fixture->initializeArgumentsAndRender());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function resultIsCorrectlyInterpretedAsJsonFromASimpleValue()
     {
         $array = [
@@ -90,9 +87,7 @@ public function resultIsCorrectlyInterpretedAsJsonFromASimpleValue()
         self::assertSame('b', $this->fixture->initializeArgumentsAndRender());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function resultIsCorrectlyInterpretedAsTextFromASimpleValue()
     {
         $array = [
@@ -110,9 +105,7 @@ public function resultIsCorrectlyInterpretedAsTextFromASimpleValue()
         self::assertSame('b', $this->fixture->initializeArgumentsAndRender());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function providingANonexistingKeyReturnsNull()
     {
         $array = [

diff --git a/Tests/Unit/ViewHelpers/Find/FacetIsActiveViewHelperTest.php b/Tests/Unit/ViewHelpers/Find/FacetIsActiveViewHelperTest.php
@@ -26,6 +26,7 @@
  *  This copyright notice MUST APPEAR in all copies of the script!
  * ************************************************************* */
 
+use PHPUnit\Framework\Attributes\Test;
 use Subugoe\Find\ViewHelpers\Find\FacetIsActiveViewHelper;
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
 use TYPO3\TestingFramework\Core\BaseTestCase;
@@ -47,9 +48,7 @@ protected function setUp(): void
         $this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function activeFacetIsCorrectlyRecognized()
     {
         $arguments = [
@@ -75,9 +74,7 @@ public function activeFacetIsCorrectlyRecognized()
         self::assertTrue($this->fixture->initializeArgumentsAndRender());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function notActiveFacetsReturnFalse()
     {
         $arguments = [

diff --git a/Tests/Unit/ViewHelpers/Find/FacetLinkArgumentsViewHelperTest.php b/Tests/Unit/ViewHelpers/Find/FacetLinkArgumentsViewHelperTest.php
@@ -26,6 +26,7 @@
  *  This copyright notice MUST APPEAR in all copies of the script!
  * ************************************************************* */
 
+use PHPUnit\Framework\Attributes\Test;
 use Subugoe\Find\Tests\Unit\ViewHelpers\MockRenderingContextTrait;
 use Subugoe\Find\ViewHelpers\Find\FacetLinkArgumentsViewHelper;
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
@@ -50,9 +51,7 @@ protected function setUp(): void
         $this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function filterIsCorrectlyRemovedOnTextQueries()
     {
         $this->fixture->setArguments([
@@ -66,9 +65,7 @@ public function filterIsCorrectlyRemovedOnTextQueries()
         self::assertEquals('tx_find_find[facet][title]', $result[0]);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function filterIsCorrectlyAddedOnTextQueries()
     {
         $this->fixture->setArguments([

diff --git a/Tests/Unit/ViewHelpers/Find/HighlightFieldViewHelperTest.php b/Tests/Unit/ViewHelpers/Find/HighlightFieldViewHelperTest.php
@@ -26,6 +26,8 @@
  *  This copyright notice MUST APPEAR in all copies of the script!
  * ************************************************************* */
 
+use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
+use PHPUnit\Framework\Attributes\Test;
 use Subugoe\Find\ViewHelpers\Find\HighlightFieldViewHelper;
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
 use TYPO3\TestingFramework\Core\BaseTestCase;
@@ -52,11 +54,8 @@ protected function setUp(): void
         $this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
     }
 
-    /**
-     * @test
-     *
-     * @doesNotPerformAssertions
-     */
+    #[Test]
+    #[DoesNotPerformAssertions]
     public function fieldIsCorrectlyHighlighted()
     {
         self::markTestIncomplete('Still something to do with mocking solarium');

diff --git a/Tests/Unit/ViewHelpers/Find/PageNumberForResultNumberViewHelperTest.php b/Tests/Unit/ViewHelpers/Find/PageNumberForResultNumberViewHelperTest.php
@@ -26,6 +26,7 @@
  *  This copyright notice MUST APPEAR in all copies of the script!
  * ************************************************************* */
 
+use PHPUnit\Framework\Attributes\Test;
 use Subugoe\Find\Tests\Unit\ViewHelpers\MockRenderingContextTrait;
 use Subugoe\Find\ViewHelpers\Find\PageNumberForResultNumberViewHelper;
 use TYPO3\CMS\Fluid\Core\Rendering\RenderingContext;
@@ -51,9 +52,7 @@ protected function setUp(): void
         $this->fixture->setRenderingContext($this->getMockBuilder(RenderingContext::class)->disableOriginalConstructor()->getMock());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function pageNumberIsCorrectlyCalculated()
     {
         $resultNumber = 55;
@@ -68,9 +67,7 @@ public function pageNumberIsCorrectlyCalculated()
         self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function pageNumerWhenResultIsZero()
     {
         $resultNumber = 0;
@@ -86,9 +83,7 @@ public function pageNumerWhenResultIsZero()
         self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function divisionByZeroIsCaught()
     {
         $resultNumber = 0;
@@ -103,7 +98,8 @@ public function divisionByZeroIsCaught()
         self::assertSame($expected, $this->fixture->initializeArgumentsAndRender());
     }
 
-    public function pageNumberFallBackForZeroResultsPerPage()
+    #[Test]
+    public function pageNumberFallBackForZeroResultsPerPage(): void
     {
         $resultNumber = 55;
         $resultsPerPage = 0;