fix: Sort arguments by name in SDL #183
Merged
+25
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuebingerb
force-pushed
the
fix/sorted-sdl
branch
from
11b8814 to
99117f0
Compare
`SchemaPrinter` already sorts types and fields by name but similar sorting for arguments was missing. Arguments in GraphQL are unordered, so let's make it consistent and a bit more readable. Also fixes test setups by enforcing unique names for input objects (cf. #167) and skips checking input objects for null or empty input fields, as they must have at least one.
stuebingerb
force-pushed
the
fix/sorted-sdl
branch
from
99117f0 to
4bf0fc6
Compare
mervyn-mccreight
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SchemaPrinteralready sorts types and fields by name but similar sorting for arguments was missing. Arguments in GraphQL are unordered, so let's make it consistent and a bit more readable.Also fixes test setups by enforcing unique names for input objects (cf. #167) and skips checking input objects for null or empty input fields, as they must have at least one.