Skip to content
This repository was archived by the owner on Jun 14, 2022. It is now read-only.

block-newsletter component - Validate register_block_type function exists #363

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

seemly
Copy link

@seemly seemly commented May 1, 2020

Installing and activating the plugin threw an error when attempting to call the function "register_block_type".

@seemly seemly changed the title check that register_block_type function exists before calling block-newsletter component - Validate register_block_type function exists May 1, 2020
@mindctrl
Copy link
Contributor

mindctrl commented May 1, 2020

@seemly which version of WP are you using?

@seemly
Copy link
Author

seemly commented May 1, 2020

@mindctrl I just tried to replicate the issue on my local machine. It seems to be an issue on older versions, so this may not be deemed an issue. I went back to 4.9 and I was then able to replicate the error.

I was just setting up a project on a cloud based coding platform (codeanywhere.com), which auto creates the environment for you. Clearly the default install version of Wordpress needs updating on their end.

I looked through the Atomic Blocks existing codebase and saw that other components had validation for function_exists on register_block_type, so I thought I would just submit a quick PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants