Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposing a way to test polling behavior in STPPaymentHandler #4521

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wooj-stripe
Copy link
Collaborator

Summary

Motivation

Testing

Changelog

Copy link

emerge-tools bot commented Jan 31, 2025

⚠️ 1 new unused protocol, 7 builds increased size, 1 build decreased size

Name Version Download Change Install Change Approval
StripeSize
com.stripe.StripeSize
1.0 (1) 2.1 MB ⬇️ 123 B 6.9 MB ⬆️ 2.7 kB (0.04%) N/A
StripePaymentsSize
com.stripe.StripePaymentsSize
1.0 (1) 1.2 MB ⬇️ 1.2 kB (-0.1%) 4.2 MB ⬆️ 2.7 kB (0.07%) N/A
StripePaymentsUISize
com.stripe.StripePaymentsUISize
1.0 (1) 1.9 MB ⬇️ 745 B (-0.04%) 6.4 MB ⬆️ 3.1 kB (0.05%) N/A
StripePaymentSheetSize
com.stripe.StripePaymentSheetSize
1.0 (1) 3.7 MB ⬇️ 5.5 kB (-0.15%) 11.1 MB ⬇️ 17.8 kB (-0.16%) N/A
StripeIdentitySize
com.stripe.StripeIdentitySize
1.0 (1) 1.4 MB ⬇️ 2.3 kB (-0.17%) 4.4 MB ⬆️ 288 B N/A
StripeApplePaySize
com.stripe.StripeApplePaySize
1.0 (1) 486.5 kB ⬇️ 2.2 kB (-0.45%) 1.7 MB ⬆️ 4.1 kB (0.25%) N/A
StripeFinancialConnectionsSize
com.stripe.StripeFinancialConnectionsSize
1.0 (1) 1.5 MB ⬇️ 2.9 kB (-0.19%) 4.8 MB ⬆️ 280 B N/A
StripeConnectSize
com.stripe.StripeConnectSize
1.0 (1) 1.7 MB ⬇️ 2.3 kB (-0.14%) 5.4 MB ⬆️ 296 B N/A

StripeSize 1.0 (1)
com.stripe.StripeSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 2.7 kB (0.04%)
Total download size change: ⬇️ 123 B

Largest size changes

Item Install Size Change
StripeCore.STPAnalyticEvent.init(rawValue) ⬇️ -4.2 kB
📝 StripePayments.STPPaymentHandlerPaymentIntentActionParams.shouldC... ⬆️ 588 B
Other ⬆️ 6.3 kB
View Treemap

Image of diff

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 2.7 kB (0.07%)
Total download size change: ⬇️ 1.2 kB (-0.1%)

Largest size changes

Item Install Size Change
StripeCore.STPAnalyticEvent.init(rawValue) ⬇️ -4.2 kB
📝 StripePayments.STPPaymentHandlerPaymentIntentActionParams.shouldC... ⬆️ 588 B
Other ⬆️ 6.3 kB
View Treemap

Image of diff

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

⚠️ Found new unused protocol: EmbeddedPaymentElementDelegate
⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 3.1 kB (0.05%)
Total download size change: ⬇️ 745 B (-0.04%)

Largest size changes

Item Install Size Change
StripeCore.STPAnalyticEvent.init(rawValue) ⬇️ -4.2 kB
📝 StripePayments.STPPaymentHandlerPaymentIntentActionParams.shouldC... ⬆️ 588 B
Other ⬆️ 6.7 kB
View Treemap

Image of diff

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 17.8 kB (-0.16%)
Total download size change: ⬇️ 5.5 kB (-0.15%)

Largest size changes

Item Install Size Change
🗑 StripePaymentSheet.EmbeddedPaymentElementViewModel ⬇️ -5.6 kB
StripeCore.STPAnalyticEvent.init(rawValue) ⬇️ -4.2 kB
DYLD.Exports ⬇️ -976 B
DYLD.Fixups ⬇️ -960 B
DYLD.String Table ⬇️ -904 B
View Treemap

Image of diff

StripeIdentitySize 1.0 (1)
com.stripe.StripeIdentitySize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 288 B
Total download size change: ⬇️ 2.3 kB (-0.17%)

Largest size changes

Item Install Size Change
StripeCore.STPAnalyticEvent.init(rawValue) ⬇️ -4.2 kB
Other ⬆️ 4.5 kB
View Treemap

Image of diff

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 4.1 kB (0.25%)
Total download size change: ⬇️ 2.2 kB (-0.45%)

Largest size changes

Item Install Size Change
StripeCore.STPAnalyticEvent.init(rawValue) ⬇️ -4.2 kB
Other ⬆️ 8.3 kB
View Treemap

Image of diff

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 280 B
Total download size change: ⬇️ 2.9 kB (-0.19%)

Largest size changes

Item Install Size Change
StripeCore.STPAnalyticEvent.init(rawValue) ⬇️ -4.2 kB
Other ⬆️ 4.4 kB
View Treemap

Image of diff

StripeConnectSize 1.0 (1)
com.stripe.StripeConnectSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 296 B
Total download size change: ⬇️ 2.3 kB (-0.14%)

Largest size changes

Item Install Size Change
StripeCore.STPAnalyticEvent.init(rawValue) ⬇️ -4.2 kB
Other ⬆️ 4.5 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Copy link

github-actions bot commented Jan 31, 2025

🚨 New dead code detected in this PR:

STPPaymentHandlerActionParams.swift:149 warning: Property 'pollingStartTime' is assigned, but never used

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant