Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for client auth using TLS #325

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alesharik
Copy link

Closes #197
Fork of PR #267 , and it's rebase attempt, because seems like original PR is unmaintained

@lightistor
Copy link

@lhotari can we get assistance in getting this PR merged?

@lhotari
Copy link
Member

lhotari commented Feb 19, 2025

Thanks for the contribution @alesharik. Would it be possible to add some tests to validate the added feature?
I'm not familiar to this code base and how it's tested.

@lhotari
Copy link
Member

lhotari commented Feb 19, 2025

@freeznet @mattisonchao Please review this PR.

@alesharik
Copy link
Author

Hi, @lhotari
I think yes. I'll look into that tomorrow

@lhotari
Copy link
Member

lhotari commented Feb 21, 2025

Hi, @lhotari I think yes. I'll look into that tomorrow

@alesharik Thanks! There doesn't seem to be very many tests in the project currently. Improving on that in this area could require more effort than usual because of the lack of examples of how things are handled in pulsar-rs.

@alesharik
Copy link
Author

@lhotari hi!
I added copy of roundtrip test which connects over TLS. Also added all necessary certs (in .github/certs), script to generate them and modified CI to run Pulsar in TLS+plain mode. It works on local machine when running Pulsar 3.1.3 with command provided in CI; but I am not sure if it will run in Github Actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for TLS Authentication
4 participants