Refactor thread mode and batch memory control #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobertIndie
reviewed
Dec 18, 2024
Comment on lines
+65
to
+68
| // Wait if the batch needs to be flushed | ||
| while (needFlush()) { | ||
| notFull.await(); | ||
| } |
There was a problem hiding this comment.
Can we schedule the flush immediately here and so that we don't nee the notFull?
There was a problem hiding this comment.
This class does not handle flush.
RobertIndie
approved these changes
Jan 6, 2025
shibd
added a commit
to shibd/pulsar-io-cloud-storage
that referenced
this pull request
Jan 7, 2025
* Refactor thread mode and batch memory control * Update docs * update pulsar version * optimize list (cherry picked from commit 7ddce6a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's difficult to control the actual size of each batch with the current batching because using only a blocking queue doesn't allow for backpressure based on byte size.
Modifications
BatchSizeorBatchBytesSizewill bock write thread.Verifying this change
CloudStorageSinkBatchBlendTestandCloudStorageSinkBatchPartitionedTestpass directly, proving there are no breaking changes.Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)