Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphiQL packages upgrade to latest #3227

Merged

Conversation

rodrigofeijao
Copy link
Contributor

Description

Upgrade GraphiQL packages to latest:

  • graphiql@3.0.9
  • @graphiql/plugin-explorer@1.0.2

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@botberry
Copy link
Member

botberry commented Nov 15, 2023

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


This release updates the GraphiQL packages to their latest versions:

  • graphiql@3.0.9
  • @graphiql/plugin-explorer@1.0.2

Here's the tweet text:

🆕 Release (next) is out! Thanks to Rodrigo Feijao for the PR 👏

Get it here 👉 https://beta.strawberry.rocks/release/(next)

@@ -61,14 +61,14 @@
<link
crossorigin
rel="stylesheet"
href="https://unpkg.com/graphiql@3.0.5/graphiql.min.css"
href="https://unpkg.com/graphiql@3.0.9/graphiql.min.css"
integrity="sha384-yz3/sqpuplkA7msMo0FE4ekg0xdwdvZ8JX9MVZREsxipqjU4h8IRfmAMRcb1QpUy"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uh I think we might need to change the SHAs as well 😊

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point! Let me update them. tks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently some of them use the same hash. 🤷
Cheked using: https://www.srihash.org/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, didn't know about that tool! thanks :) I'll check if it all works and then I'll release :)

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #3227 (0ca6948) into main (d6bd38d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3227      +/-   ##
==========================================
- Coverage   96.60%   96.60%   -0.01%     
==========================================
  Files         481      481              
  Lines       29928    29928              
  Branches     3691     3691              
==========================================
- Hits        28912    28911       -1     
  Misses        833      833              
- Partials      183      184       +1     

Copy link

codspeed-hq bot commented Nov 15, 2023

CodSpeed Performance Report

Merging #3227 will not alter performance

Comparing rodrigofeijao:feat/update-graphiql-packages (0ca6948) with main (d6bd38d)

Summary

✅ 12 untouched benchmarks

RELEASE.md Outdated Show resolved Hide resolved
@patrick91
Copy link
Member

thank you so much!

@patrick91
Copy link
Member

I'll fix the lint errors and then merge, those are not related to this PR

@patrick91 patrick91 merged commit 663aa2e into strawberry-graphql:main Nov 15, 2023
59 of 61 checks passed
@botberry
Copy link
Member

Thanks for contributing to Strawberry! 🎉 You've been invited to join
the Strawberry GraphQL organisation 😊

You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67

And don't forget to join our discord server: https://strawberry.rocks/discord 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants