change: parse query params to use parse_json (#3272)

* change: parse query to use parse_json * docs: release file * fix: extraneous typing
strawberry-graphql · Dec 6, 2023 · fdb87ec · fdb87ec
1 parent f0332fc
commit fdb87ec
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/RELEASE.md b/RELEASE.md
@@ -0,0 +1,3 @@
+Release type: patch
+
+Fixed the base view so it uses `parse_json` when loading parameters from the query string instead of `json.loads`.
diff --git a/strawberry/http/async_base_view.py b/strawberry/http/async_base_view.py
@@ -217,7 +217,7 @@ async def parse_http_body(
 
         return GraphQLRequestData(
             query=data.get("query"),
-            variables=data.get("variables"),  # type: ignore
+            variables=data.get("variables"),
             operation_name=data.get("operationName"),
         )
 

diff --git a/strawberry/http/base.py b/strawberry/http/base.py
@@ -44,7 +44,7 @@ def should_render_graphql_ide(self, request: BaseRequestProtocol) -> bool:
     def is_request_allowed(self, request: BaseRequestProtocol) -> bool:
         return request.method in ("GET", "POST")
 
-    def parse_json(self, data: Union[str, bytes]) -> Dict[str, str]:
+    def parse_json(self, data: Union[str, bytes]) -> Any:
         try:
             return json.loads(data)
         except json.JSONDecodeError as e:
@@ -65,7 +65,7 @@ def parse_query_params(
                 variables = variables[0]
 
             if variables:
-                params["variables"] = json.loads(variables)
+                params["variables"] = self.parse_json(variables)
 
         return params
 

diff --git a/strawberry/http/sync_base_view.py b/strawberry/http/sync_base_view.py
@@ -157,7 +157,7 @@ def parse_http_body(self, request: SyncHTTPRequestAdapter) -> GraphQLRequestData
 
         return GraphQLRequestData(
             query=data.get("query"),
-            variables=data.get("variables"),  # type: ignore
+            variables=data.get("variables"),
             operation_name=data.get("operationName"),
         )
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		Release type: patch

		Fixed the base view so it uses `parse_json` when loading parameters from the query string instead of `json.loads`.