Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

need to rename pool_signature field of channel_factory into additional_coinbase_script_data, and change the type from String to Vec<u8> #1436

Open
GitGab19 opened this issue Feb 3, 2025 · 0 comments · May be fixed by #1442
Open

need to rename pool_signature field of channel_factory into additional_coinbase_script_data, and change the type from String to Vec<u8> #1436

GitGab19 opened this issue Feb 3, 2025 · 0 comments · May be fixed by #1442
Assignees
@plebhash
Labels
refactor Implies refactoring code roles-logic-sv2

Comments

@GitGab19
Copy link
Collaborator

GitGab19 commented Feb 3, 2025

First task from the original PR: #1248 (comment)
@GitGab19 GitGab19 added refactor Implies refactoring code roles-logic-sv2 labels Feb 3, 2025
@plebhash plebhash changed the title Rename pool signature field of the channel factory into coinbase_script_additional_data, and change the type from String to Vec<u8> need to rename pool_signature field of channel_factory into additional_coinbase_script_data, and change the type from String to Vec<u8> Feb 3, 2025
@plebhash plebhash linked a pull request Feb 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plebhash plebhash

Labels
refactor Implies refactoring code roles-logic-sv2
Projects
None yet
Milestone
No milestone
2 participants
@GitGab19 @plebhash