-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extended mdp executor depends on door_pass #257
Comments
The dependency comes from the door prediction service. The modelling of door states in the MDP is quite specific, and done so that it is transparent to the user. While we could abstract it a bit, that would require a lot of effort and refactoring... Also, why is door_pass on strands_apps? This problem would be solved if it went to strands_navigation, or if we created a new repo with specialised nav actions. |
It’s not just the repo location. door_pass requires things like speech and the webserver, which are essential for physically passing the door, but are unrelated to the prediction task. If we’re wanting people to use the mdp planning framework in other applications, I think this could be a bit of an issue (although perhaps this is no different from a dependency on topological navigation). |
well, topo nav makes more sense at least. We could have general door models, and just ask for an action server with a specific goal message type to be available at The prediction part would have to be independent from the door passing action server though, also assuming that the door stats have a particular type |
Hi a question on a very related topic. I am working on a general tool for creating temporal models from any mongo query (or frongo), maybe we can generalise a way to define all the predictions you will need for navigation actions and a standard prediction service you can use? Now my problem I'm developing this tool (frongo) in strands_apps so we keep |
Why not making it part of fremen repo? The released packages will remain independent. And for the repo, it doesn't hurt, does it? |
yes I guess that would be alright since we have no metapackages in Fremen right now. |
Which adds a whole chain of unwanted dependencies for this package. This should be fixed someone.
The text was updated successfully, but these errors were encountered: