Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integration Tests for GroupingWorkflows and Ensure Idempotency in License Attachment #57

Closed
wants to merge 11 commits into from

Conversation

sebsadface
Copy link
Member

Description

This PR introduces integration tests for GroupingWorkflows and ensures idempotency when attaching license terms in GroupingWorkflows.

Key Changes

  • Added the attachLicenseTerms helper function, which attaches license terms only if they haven't been applied already. GroupingWorkflows now uses this helper instead of calling LicensingModule directly.
  • Removed the local implementation of StorageLayoutCheck and updated DeployHelper to import it directly from protocol core.
  • Added BaseIntegration.t.sol and Users.t.sol to encapsulate setup logic for integration tests and mock user creation.
  • Added tests to cover all functions of GroupingWorkflows, including multicall scenarios, running in a forked public testnet environment.
  • Added a temporary file to store the latest core protocol deployment addresses.
  • Modified StoryProtocolCoreAddressManager to optionally read from the temporary deployment address file when the isTest flag is true.
  • Miscellaneous Fixes: Added EVM version, removed unnecessary imports, fixed state variable visibility, and applied minor style improvements.

Test Plan

All existing and new tests pass locally.

Related Issue

Copy link
Collaborator

@kingster-will kingster-will left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
couple comments.

@sebsadface sebsadface force-pushed the integration-tests branch 3 times, most recently from 91a0e2d to ba05783 Compare September 10, 2024 06:24
@sebsadface sebsadface closed this Sep 10, 2024
@sebsadface sebsadface deleted the integration-tests branch September 13, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants