Add Integration Tests for GroupingWorkflows
and Ensure Idempotency in License Attachment
#57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces integration tests for
GroupingWorkflows
and ensures idempotency when attaching license terms inGroupingWorkflows
.Key Changes
attachLicenseTerms
helper function, which attaches license terms only if they haven't been applied already.GroupingWorkflows
now uses this helper instead of callingLicensingModule
directly.StorageLayoutCheck
and updatedDeployHelper
to import it directly from protocol core.BaseIntegration.t.sol
andUsers.t.sol
to encapsulate setup logic for integration tests and mock user creation.GroupingWorkflows
, including multicall scenarios, running in a forked public testnet environment.StoryProtocolCoreAddressManager
to optionally read from the temporary deployment address file when theisTest
flag is true.Test Plan
All existing and new tests pass locally.
Related Issue