docs: improve documentation for setting licensing configuration #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit clarifies that several functions in LicenseAttachmentWorkflows can optionally set licensing configurations in addition to attaching license terms.
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
kingster-will
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the documentation for several functions in the
LicenseAttachmentWorkflowscontract to clearly that they support optional licensing configuration in addition to attaching license terms.Changes
registerPILTermsAndAttach,mintAndRegisterIpAndAttachPILTerms, andregisterIpAndAttachPILTermscan all optionally set licensing configurationsisSetis true)Why
These documentation improvements help developers better understand the capabilities of the workflow functions, particularly that licensing configuration can be set in the same transaction as license term attachment.
Testing
No functional changes were made, only documentation updates.