feat(SPGNFT): add setTokenURI function to SPGNFT Contract
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
Adds ability for NFT token owners to update their token URIs with proper access control. Only the owner of a token can update its URI. Includes: - New setTokenURI function in SPGNFT contract - Interface update in ISPGNFT - New SPGNFT__CallerNotOwner error - Test cases for successful updates and unauthorized attempts
sebsadface
force-pushed
the
feat/support-set-token-uri
branch
from
c34336a to
2b3f5ac
Compare
kingster-will
previously approved these changes
Mar 3, 2025
Renames the tokenId parameter to tokenId_ in both the SPGNFT contract and ISPGNFT interface to maintain consistent parameter naming convention.
sebsadface
force-pushed
the
feat/support-set-token-uri
branch
from
daa4afb to
2f14a63
Compare
kingster-will
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds functionality to allow NFT token owners to update their token URIs. The new
setTokenURIfunction enables token owners to modify the metadata URI of their tokens while maintaining proper access control.Changes
setTokenURIfunction toSPGNFTcontract that allows token owners to update their token URIsISPGNFTSPGNFT__CallerNotOwnererror for unauthorized access attemptsTesting
test_SPGNFT_setTokenURI()to verify successful token URI updatestest_SPGNFT_setTokenURI_revert_callerNotOwner()to verify access controlRelated Issues
tokenURIUpdates in SPGNFT #188