fix(story-nft): enforce max balanceOf() of 1 for each address #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
kingster-will
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances security in the
StoryBadgeNFTandOrgStoryNFTFactorycontracts by adding additional validation checks to prevent duplicate minting scenarios.For
StoryBadgeNFT, we now verify that a recipient can only hold one badge NFT by checking their balance before minting, regardless of signature changes. Similarly forOrgStoryNFTFactory, we validate that an organization NFT recipient doesn't already have an NFT before deployment.These changes are accompanied by new error types (
StoryBadgeNFT__RecipientAlreadyHasBadge) and test cases to verify the updated behavior.