refactor(workflows): replace permission setting with executeWithSig
#121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebsadface
requested review from
kingster-will,
Spablob and
LeoHChen
as code owners
kingster-will
approved these changes
Nov 20, 2024
sebsadface
added a commit
to sebsadface/pp-v1
that referenced
this pull request
Nov 28, 2024
…teWithSig` (storyprotocol#121)" This reverts commit a6fbf2c. Revert "feat(licensing): support custom license templates and decouple terms registration from attachment (storyprotocol#123)" This reverts commit 68f4a4a. Revert "feat(licensing): enable multi-license attachment (storyprotocol#128)" This reverts commit 027eed9.
sebsadface
added a commit
to sebsadface/pp-v1
that referenced
this pull request
Nov 28, 2024
…teWithSig` (storyprotocol#121)" This reverts commit a6fbf2c. Revert "feat(licensing): support custom license templates and decouple terms registration from attachment (storyprotocol#123)" This reverts commit 68f4a4a. Revert "feat(licensing): enable multi-license attachment (storyprotocol#128)" This reverts commit 027eed9.
sebsadface
added a commit
that referenced
this pull request
Nov 29, 2024
…teWithSig` (#121)" (#133) * Revert "refactor(permission): enable direct function calls via `executeWithSig` (#121)" This reverts commit a6fbf2c. Revert "feat(licensing): support custom license templates and decouple terms registration from attachment (#123)" This reverts commit 68f4a4a. Revert "feat(licensing): enable multi-license attachment (#128)" This reverts commit 027eed9. * test(derivative): fix stack too deep
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors workflow contracts to use the
executeWithSigfunction fromIPAccount, and enables direct calls to core protocol functions on behalf of the IP owner. This eliminates the need to grant extended permissions to workflow contracts via the protocol access controller, which enhances the security of periphery contracts by ensuring permissions are limited to the duration of a single workflow function call.KeyChanges:
PermissionHelper, the library contract previously used for setting permissions for periphery contracts.MetadataHelperto leverageexecuteWithSigfor invoking core protocol functions, removing reliance on permission setting.LicensingHelperto support registering and attaching PIL terms usingexecuteWithSig.DerivativeWorkflowsto account for whetherexecuteWithSigis used. This makes sure proper handling of minting fees and license tokens depending on whethermsg.senderof the core protocol function is the workflow contract or the IP account.executeWithSigfor core protocol functions that require IP account permissions.mintAndRegisterIpAndAttachLicenseAndAddToGroupinGroupingWorkflowsstill sets permissions through the access controller because theipIdis not known at the time of the function call. There are no known security issues for this approach.Test Plan
The tests are updated to reflect these changes and all tests pass locally.
Related Issue
executeWithSigfor Direct Function Calls #110Notes
This PR include API changes, and requires updates to downstream integrations.